Added documentation for conditional mocks #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
requested changes
Feb 22, 2019
clients/mock-client.rst
Outdated
| class YourTest extends \PHPUnit_Framework_TestCase | ||
| { | ||
| /** | ||
| * @expectedException \Exception |
There was a problem hiding this comment.
i'd prefer dock to follow best practices and do $this->expectException(\Exception::class); in the code, on the line before sending the request.
clients/mock-client.rst
Outdated
|
|
||
| // $requestMatcher is an instance of Http\Message\RequestMatcher | ||
|
|
||
| $response = $this->createMock('Psr\Http\Message\ResponseInterface'); |
There was a problem hiding this comment.
please use use statements and the ::class pseudo constant (for the code, the comment about $requestMatcher is fine.
clients/mock-client.rst
Outdated
|
|
||
| // $requestMatcher is an instance of Http\Message\RequestMatcher | ||
|
|
||
| $response = $this->createMock('Psr\Http\Message\ResponseInterface'); |
There was a problem hiding this comment.
should this not be an exception for the test to behave as expected?
|
I'd agree with all the comments. On some of the style preferences, there's a couple of places in the docs which might want to be updated to match, for consistency if that's the preferred style. I've updated the pull-request anyway - hope that's better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #255 and php-http/mock-client#27